Sam Atkins
Sam Atkins
Wait, I just noticed CI is failing on that test still... For reference, `Meta/serenity.sh test lagom LibWeb` will run the tests locally.
From the commit message: > In most cases, trailing `requires` clauses and those specified after the template parameter list, so this change should not impact the code's behavior. I think...
This seems harmless enough. Might be tricky to avoid letting more of these show up, but we don't use `requires` _that_ often, so it's probably fine.
> @AtkinsSJ I will make these changes (and will squash/rebase down to 1 commit), but in the meantime I did have a question around what the correct error handling should...
Oh also you don't need to only have a single commit per PR, just that if you have a commit, then later need to fix a mistake you made in...
The CI logs had expired so I've restarted them.
I've just noticed this has conflicts, please rebase on master and fix them up. Also, once you've dealt with some feedback, click on the "Resolve conversation" button. It makes it...
This consistently fails `TestTLSHandshake`, both on CI and locally for me. (But the test passes without this.) ``` FAIL LibTLS/TestTLSHandshake (2.117323s) Test: TestTLSHandshake (failed) Running test 'test_TLS_hello_handshake'. FAIL: Tests/LibTLS/TestTLSHandshake.cpp:61: name...
Not stale! Though I had forgotten about this. 😅
Same again. I can't believe this has been open 2 months. :thousandyakstare: