Askaholic

Results 115 comments of Askaholic

Hm, we could probably change the server to use kick there too

Ok interesting. Thanks for the link

I've had `tests/integration_tests/test_matchmaker.py::test_anti_map_repetition` time out on me twice now. Seems like sometimes it can take a long time for `queue_players_for_matchmaking` to complete when running in that loop. https://github.com/FAForever/server/pull/775/checks?check_run_id=2371885906 EDIT: I...

Now I got a failure in `tests/integration_tests/test_teammatchmaker.py::test_ratings_initialized_based_on_global_persisted`. https://github.com/FAForever/server/pull/775/checks?check_run_id=2422009708 https://github.com/FAForever/server/pull/781/checks?check_run_id=2422721702

These are probably the 2 most sophisticated python libraries out there for detecting profanity: https://pypi.org/project/profanity-filter/ https://github.com/vzhou842/profanity-check Other libraries are mostly just simple word lists.

Makes sense. Probably the right thing to do would be to add the rating to the `game_launch` message?

Yea we have to do it on both. The client can do it on a user friendly way that provides instant and localized feedback, but the server is the only...

It’s still a breaking API change. I’ve written a bit about this topic here: https://github.com/FAForever/server/blob/develop/CONTRIBUTING.md#version-numbers

No? The client should not depend on a breaking change existing, especially when that change isn’t merged.

Yea there were a number of things that came up that should really be in the readme, like required software: - docker - Python 3.7 (with loadable SQLite extensions) -...