server
server copied to clipboard
FAForever
Integration test flakiness
In a recent PR of mine I had a handful of integration tests fail on me intermittently when run by GitHub Actions; they passed fine locally. The errors seem related to connecting to rabbitmq, but that might just be a symptom of something else.
In one run tests/integration_tests/test_control_server.py::test_game and tests/integration_tests/test_control_server.py::test_players gave the following error: OSError: [Errno 99] error while attempting to bind on address ('10.1.1.42', 4001): cannot assign requested address.
In another run tests/integration_tests/test_matchmaker.py::test_game_matchmaking_close_fa_and_requeue failed with ConnectionRefusedError: [Errno 111] Connect call failed ('127.0.0.1', 5672).
FYI, this seems to be caused by https://github.com/actions/virtual-environments/issues/3185 . Reverse name lookup for current hostname is broken.
I've had tests/integration_tests/test_matchmaker.py::test_anti_map_repetition time out on me twice now. Seems like sometimes it can take a long time for queue_players_for_matchmaking to complete when running in that loop.
https://github.com/FAForever/server/pull/775/checks?check_run_id=2371885906
EDIT: I think I've resolved this in #775 by increasing the timeout.
Now I got a failure in tests/integration_tests/test_teammatchmaker.py::test_ratings_initialized_based_on_global_persisted.
https://github.com/FAForever/server/pull/775/checks?check_run_id=2422009708 https://github.com/FAForever/server/pull/781/checks?check_run_id=2422721702
Got a failure on tests/integration_tests/test_load.py::test_game_info_broadcast_on_connection_error after testing my branch 5 times. First time i have seen this one fail. Also getting the other matchmaking ones as well.
