server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon FAForever

Use string for faction in game launch message

Open Sheikah45 opened this issue 3 years ago • 6 comments

It would be nice to consistently use the string version of faction in all the messages from the server. All clients going back to 1.4.6 are able to handle the faction as a string.

1.4.6 is the current minimum version of the client

Sheikah45 avatar Sep 13 '21 12:09 Sheikah45

I don't know if this needs to wait until v2.0 since all clients are designed to be able to use a string or an int as the faction serialization. So it is not a breaking change.

Sheikah45 avatar Sep 13 '21 15:09 Sheikah45

It’s still a breaking API change. I’ve written a bit about this topic here: https://github.com/FAForever/server/blob/develop/CONTRIBUTING.md#version-numbers

Askaholic avatar Sep 13 '21 16:09 Askaholic

Does that mean that client version 1.6 has to wait for server v2.0?

BlackYps avatar Sep 15 '21 19:09 BlackYps

No? The client should not depend on a breaking change existing, especially when that change isn’t merged.

Askaholic avatar Sep 15 '21 19:09 Askaholic

Seems like Sheikah has some work to do to fix the release candidate then xD

BlackYps avatar Sep 15 '21 21:09 BlackYps

I actually already have a pr that fixes it. Just requested this on principle XP

Sheikah45 avatar Sep 15 '21 22:09 Sheikah45