Arthur Silva Sens

Sorry for taking so long, but PR rebased! I believe it should be ready for a review 🙂

I'm reading the code again and I think you might be correct... I'm not sure what we want to do here though, we could 1) fix the comment to reflect...

Thanks for the detailed explanation of your use case! I agree that what you described is probably more common in reality

Issue solved upstream, should be good to advance here once new release is out!

I believe he meant #1313

> Hello, I'd like to work on this issue Let us know if you need any assistance :)

Just noticed that Björn was quicker than us with the client_model PR. Feel free to directly ping me in the prometheus/common PR if you need reviewers, I don't receive notifications...

I'm not sure if this is a safe change for downstream projects 😬. I see a pattern amongst Kubernetes controllers to declare those types of constants in the same package...

@xiu have you had the chance to take a look at the comment above?

What I'm not sure is if we want to wait for a more complete ScrapeConfig CRD before deprecating additionalScrapeConfigs officially 🤔