add _created support: add createdTime() method to counter

[andysim3d]

first step of issue #685

Signed-off-by: Pengfei Zhang [email protected]

[andysim3d]

@beorn7 Please take a look since you are the original owner of that issue.

[beorn7]

While I opened this issue, this has to be figured out between the OpenMetrics experts and the current maintainers of prometheus/client_golang.

From a very general perspective, I don't think Created() should be a method (similar to not making the counter value itself accessible via some kind of Get() method).

[pintohutch]

Hello,

Is this still being discussed?

[logicalhan]

Can we please do this? _created timeseries is a necessary prerequisite for upstream Kubernetes to even consider supporting prometheus' open-metrics format.

[kakkoyun]

Can we please do this? _created timeseries is a necessary prerequisite for upstream Kubernetes to even consider supporting prometheus' open-metrics format.

I will check-in with maintainers about this again.

[bwplotka]

BTW, @ArthurSens, our mentee works on adding created timestamp with tests https://github.com/prometheus/client_golang/pull/1044

[bwplotka]

Done in https://github.com/prometheus/client_golang/pull/1044, so closing this PR. Thanks anyway!

[logicalhan]

Done in #1044, so closing this PR. Thanks anyway!

this is PR #1044...

[ArthurSens]

I believe he meant #1313