Arthur Silva Sens

Results 418 comments of Arthur Silva Sens

Hey, thanks for the PR! Could you sign the commits to make CI happy? I'm assuming the efficiency improvement here is that we don't need to allocate memory for metric...

If we move forward with renovate, I'd love to see [this workflow](https://github.com/prometheus/client_golang/blob/main/.github/workflows/automerge-dependabot.yml) still working 🙈. It currently depends on the github action dependabot/fetch-metadata, not sure how this works with renovate

I just haven't figure out how to render that yet 😅, but agreed that markdown is easier/better

Couldn't find the time to proceed with this 😬

The fix would be in this regex: https://github.com/prometheus-operator/prometheus-operator/blob/ff2896aa778577ff26486c115d788e05da4d7310/pkg/apis/monitoring/v1/types.go#L40 A test case showing that we reject configs that us `0s` as duration would also be good :)

Feel free to work on it, just please cherry-pick the author's commit so he also get some credits :)

Hey, I've read the linked issue but I couldn't understand why we would want different roles in ServiceMonitors that are not Endpoint or EndpointSlice. (Already being worked on in https://github.com/prometheus-operator/prometheus-operator/pull/6518)...

> simonpasquier getting > > ``` > Error: pkg/prometheus/promcfg.go:1815:84: cannot use am.Namespace (variable of type *string) as string value in argument to store.ForNamespace > ``` > > but cant find...

Hey 👋 , pardon my ignorance, could you update your PR description mentioning how this change improves performance? I saw the title mentions that we're now allocating label values on...

The Gatherer interface, implemented by the registry, has the method `Gather` that returns all metric families that were already collected by the registry. One could already implement the described behavior...