Arthur Silva Sens
Arthur Silva Sens
I was taking a look at the report provided by the badge, I'm not sure I understood why we got 0 with Token-Permissions. I don't guarantee that all permissions were...
This PR is also making changes to Dockerfile, which doesn't seem related to the OSSF scorecard, could we split it into a separate PR? It could make the merge process...
> It is related as ossf ask for dependencies to use pinned version for docker as for github-actions. Please have a look here https://securityscorecards.dev/viewer/?uri=github.com/prometheus/client_golang > > I’m fine seing this...
Circular dependency has been solved after moving the version collector to client_golang! https://github.com/prometheus/common/pull/579 https://github.com/prometheus/common/pull/591 https://github.com/prometheus/client_golang/pull/1422
We need prometheus/common v0.49.0 for this feature, but this version of prometheus/common requires go 1.21. Therefore, the PR is blocked until we drop support for go 1.20
After quite some work to unblock this, this is finally ready :) Do you want to review again or should I just merge?
Now that https://github.com/prometheus/prometheus/pull/14356 was merged, should we revive this? :)
PR rebased on main. Ready for another review just in case @kakkoyun @bwplotka @vesari
Since we have approvals from the past, I'll take the liberty to merge this PR next week :)
> should we add summaries and counters in the example too? So far all our examples just add one or two metrics, not sure if that's needed 🤷