Arthur Milchior

Results 101 issues of Arthur Milchior

Waiting For Feedback

Now that HashUtil methods are not used in Java anymore (at least once #12301 is merged. But my two commits can be reviewed independently of #12301), I can make them...

Waiting For Feedback

Also renaming dcid to DeckConfId which is more Kotlin-like. Also dealt, separately, with collection of longs Those IDs were not found by the initial simple search. For those, I had...

Needs Second Approval

While looking at #11113, I found a small place where a scope function could remove some !!. Then I cleaned some related nullable variable. And found one part where code...

Waiting For Feedback
Needs Review

On https://arrow-kt.io/docs/apidocs/arrow-core/arrow.core/-ior/ you have `Either

The system used by https://google.github.io/comprehensive-rust/exercises/day-1/book-library.html allows to execute code directly in the book. So playground references became useless. If I got it wrong, it would be nice to at least...

This page started by using `iter` and then used `into_iter`. No explanation was given. Worse, since the second part is about IntoIterator, intuition would indicate that the word "into" in...

I’d strongly suggest, in https://google.github.io/comprehensive-rust/welcome.html , to explicitely note that the Android part considers how to contribute to Android source code, using Android build system. On first reading, the way...

Not sure of the intended meaning. At least the sentence is true and gramattically correct here

Not entirely sure of the intended meaning of the second sentence. I assume I’m not too far away