Arthur Milchior

Results 101 issues of Arthur Milchior

Currently `assertEquals` only consider Long and Object. In Java, Int were converted to Long, but in Kotlin they are converted to Object. Which force conversion to explicitly write `toLong` to...

Priority-Low
Good First Issue!
Test process

Lint message around system time was not update when Time was moved to Collection from TimeManager. In my opinion, code is more readable if you just uses `Time.s` and `Time.ms`...

Waiting For Feedback
Needs Review

NotetypeId is defined upstream in models.py. Since we may not convert Models.java, defining it in consts.kt seems the better place Those variables were found by searching for "mid: Long" and...

It's used upstream. It was defined in notes.py, but since Notes.java may not get converted, consts is the most relevant place to put it. Those ones were found by searching...

In AnkiDroid you can use timebox. AnkiDroid tell you that you reviewed 27 cards in the last 15 minutes, - for example - and whether you want to stop here....

Good First Issue!
Stale

Actually, I'm using the Time object to get time, so it's a clock. This will avoid having confusion between the time accessor and some time point as I currently have...

Stale

I admit with time passing that Time itself was not part of the collection but of the system. I don't like static value, but I guess it's the more logical...

Stale

One usual issue in reading code inside of code (e.g. string containing html, css, or js) is that they contains quote, which you must escape. Worst is when you want...

Priority-Low
Good First Issue!

I made a mistake that was not seen by the reviewers. Essentially `Build.VERSION.SDK_INT` is 0 unless we use `@Config(sdk = [21, 26])` or `targetApi`. So, I would love a linter...

Good First Issue!
Test process