Arthur Milchior

Factorize close

2

Yet another part of https://github.com/ankidroid/Anki-Android/pull/11418 which can be considered separately It considers the actions that can close preferences

This remove some code duplication on the way to deal with queue. The question of whether it's actually the order in which we want preemption to accumulate remains.

I believe this version is more readable.

NF: factorize unmondReceiver creation

1

Also a part of #11418. On top of #11421 because if nullity is not taken into account, compilation fail

Most complex part of #11418. Factorizing preference hack as much as possible

Factorize deck pref

2

I was looking at #11417 and this led me to find far more duplication than I expected. If it's too hard to review all at once, I can split. The...

This can be done simply by reifying types, which itself requires inlining the function. This can't be done when the uncheckd is due to the fact that we cast to...

The file AccessibilitySettingsFragment.kt has dos line break. Which appear as "^M" in emacs. (Can also be created with `\r` usually). Three things to do: * may be nice to have...

Cleaning: replacing `format` by formatted strings

1

This is part of Kotlin clean-up #10489, low priority, a way to slightly improve code quality and make easy changes. There are currently 37 occurrences of `String.format` in Kotlin followed...

Kotlin Cleanup

69

Currently, there are 84 `@KotlinCleanup` in AnkiDroid code source. Most of those changes are supposed to be simple to do and would be a good pull request by themselves. Also,...