Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Published 20 hours ago • verified publisher icon ankidroid

Factorize close

Open Arthur-Milchior opened this issue 2 years ago • 2 comments

Yet another part of https://github.com/ankidroid/Anki-Android/pull/11418 which can be considered separately

It considers the actions that can close preferences

Arthur-Milchior avatar May 25 '22 17:05 Arthur-Milchior

AppCompatPreferenceActivity.kt will be gone when someone takes up #5019 and DeckOptions/FilteredDeckOptions probably will inherit from AnkiActivity then. Even so, these refactors may help in the future, so I'm just stating it.

BrayanDSO avatar Aug 03 '22 16:08 BrayanDSO

Thanks. FYI, @BrayanDSO , even if you can't merge a PR, you can review it. Since you seemed to already have an idea about it, you should be able to use github to approve it (or require change)

Arthur-Milchior avatar Aug 03 '22 23:08 Arthur-Milchior

@mikehardy done

Arthur-Milchior avatar Aug 19 '22 15:08 Arthur-Milchior