Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Factorize deck pref

Open Arthur-Milchior opened this issue 2 years ago • 2 comments

I was looking at #11417 and this led me to find far more duplication than I expected. If it's too hard to review all at once, I can split. The last commit is the hardest one. The first few commits, by removing some nullability thanks to late init, are really nice by themselves. Then many commits are factorizing copy-pasted code and can be considered by themselves (but would conflict with the first ones)

Arthur-Milchior avatar May 25 '22 16:05 Arthur-Milchior

Converting this to draft since it's not really an actionable PR from a review perspective, with the work split out into multiple little PRs

mikehardy avatar May 30 '22 02:05 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Jul 29 '22 03:07 github-actions[bot]

Conflict resolved

Arthur-Milchior avatar Aug 28 '22 18:08 Arthur-Milchior

@Arthur-Milchior this has some sort of compile error :thinking: ?

mikehardy avatar Sep 02 '22 14:09 mikehardy

@Arthur-Milchior squash or rebase?

david-allison avatar Sep 03 '22 15:09 david-allison

@david-allison Currently neither. You did the two approval. We should maybe wait for a review by someone else. Later, rebase

Arthur-Milchior avatar Sep 03 '22 23:09 Arthur-Milchior

@lukstbit I had no knowledge about it, I admit that enough people seems to follow the new back-end that I don’t feel like I had to go read it

Arthur-Milchior avatar Sep 10 '22 10:09 Arthur-Milchior

The new backend code will have a large impact on the future of AnkiDroid development, so as someone who reviews other people's PRs, I'd recommend getting up to speed with it.

dae avatar Sep 12 '22 10:09 dae

Any advice where to start reading about it?

Arthur-Milchior avatar Sep 12 '22 19:09 Arthur-Milchior

In this case it requires keeping track of active/merged PRs - https://github.com/ankidroid/Anki-Android/pull/12175 is the one that will introduce the new decks screen.

Related info:

  • https://github.com/ankidroid/Anki-Android/issues/11882
  • https://github.com/ankidroid/Anki-Android-Backend/blob/main/docs/OVERVIEW.md

dae avatar Sep 13 '22 02:09 dae

Hi there @Arthur-Milchior! This is the OpenCollective Notice for PRs merged from 2022-09-01 through 2022-09-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

github-actions[bot] avatar Oct 16 '22 20:10 github-actions[bot]