Anki-Android
Anki-Android copied to clipboard
ankidroid
At the end of a timebox, don't play a video
In AnkiDroid you can use timebox. AnkiDroid tell you that you reviewed 27 cards in the last 15 minutes, - for example - and whether you want to stop here. However, a second after the question appears, ankidroid starts playing the media of the next card, in particular the video moves to full screen and hides the buttons. If you want to answer the question related to the video you can't because you need to answer whether you want to continue. This means that the user switch between "do you continue" and "actual card's question" thrice, which is slightly confusing and not a good experience.
Instead, media manager, or at least videos, should wait until the user has answered that they still want to review before playing the next media.
I kind of hope that it's a good first issue, because it "only" touches two part of the code, media manager and timebox. It is not something that require to make change everywhere. However, it's not entirely trivial either since you'll need to ensure that the media manager take the state of the timebox into account (or that it is not triggered so soon)
Hello! i'm new to the community and would love to contribute to this :)
Extremely sorry @raddi1972 , @SanjaySargam , @viciousAegis , I didn't check github as much as I should have. The first one of you who confirm that they are not working on anything else for ankidroid can have it. If you are not already on discord, please come if you have any question, usually people can answer here more quickly than on github, as there are more people looking at what you ask
I am not working on anything else in ankidroid, so I would like to work on this.
@Arthur-Milchior is this issue resolved? or @raddi1972 is still working on it?
I was able to identify the problem and recreate it, I was also able to locate the code related to timebox. Could you point me, which part of the code should I look into for media manager or from where the videos are controlled? @Arthur-Milchior
I believe you may want com/ichi2/libanki/Sound.java which seems to have the method in charge of playing media. The name is admittedly confusing as it deals with video to
To fix this do we need to wait for the window to close and then play the video? I am thinking of somehow checking the state of the TimeBox window then calling the function that plays the media. Do we have a listener that can be called after the state of the TimeBox is finished? @Arthur-Milchior
That was indeed what seemed the most natural to me. If the user answer they want to still review, show the video, otherwise close
Is this issue fixed, @Arthur-Milchior ? or is it still being worked on by @raddi1972 ?
@ayushsoni916 The issue is not fixed. I am busy with university work so ig you can work on it. I will unassign myself.
@Arthur-Milchior could you provide some screenshot of this issue so I can understand it more better.
I'll try. I'll need a video however, because a screenshot will not show anything relevant
@Arthur-Milchior please send the video asap so I can work on this issue more efficiently.
https://user-images.githubusercontent.com/357361/160294311-4b93b70c-cf98-4618-80ce-cb4b2c3f377f.mp4
Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@s-deepak-kumar are you still interested? I believe we can assume @ayushsoni916 is not working on it anymore.
@s-deepak-kumar if you'rer interested, let me know if you understood the issue
Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically