Arthur Milchior

Results 217 comments of Arthur Milchior

I'll try. I'll need a video however, because a screenshot will not show anything relevant

https://user-images.githubusercontent.com/357361/160294311-4b93b70c-cf98-4618-80ce-cb4b2c3f377f.mp4

@s-deepak-kumar are you still interested? I believe we can assume @ayushsoni916 is not working on it anymore. @s-deepak-kumar if you'rer interested, let me know if you understood the issue

> com.ichi2.anki.FieldEditLineTest > testSaveRestore[test(AVD) - 10] FAILED kotlin.UninitializedPropertyAccessException: lateinit property mEditorNote has not been initialized at com.ichi2.anki.NoteEditor.onCollectionLoaded(NoteEditor.kt:456) seems to be a real error. Please correct.

Which failure are you talking about? everythnig seems to work here

> > Which failure are you talking about? everythnig seems to work here > > Ah, yesterday it had failed the windows unit test on github, seems to be fine...

To the best of my understanding, `apply` and other [scope function](https://kotlinlang.org/docs/scope-functions.html) are mainly here for readability purpose. However, there is a few exceptions to that. If you do `x!!.apply{foo}`, you...

@david-allison is it done? I don't understand what's up with Time to be honest. I believe right now it's okay

If that's not blocking anything, I'm fine with it.