[Kotlin Cleanup] NoteEditor nullability cleanup

[thedroiddiv]

Checklist

Please, go through these checks before submitting the PR.

• [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] Your code follows the style of the project (e.g. never omit braces in if statements)
• [ ] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

[Arthur-Milchior]

com.ichi2.anki.FieldEditLineTest > testSaveRestore[test(AVD) - 10] FAILED kotlin.UninitializedPropertyAccessException: lateinit property mEditorNote has not been initialized at com.ichi2.anki.NoteEditor.onCollectionLoaded(NoteEditor.kt:456)

seems to be a real error. Please correct.

[thedroiddiv]

Sorry, forgot to mark as draft earlier, was just testing right now.

[thedroiddiv]

Resolved the conflicts, ready for review. Had been open for so long, wasn't much conflicting so went well.

[github-actions[bot]]

Hi there @divyansh-dxn! This is the OpenCollective Notice for PRs merged from 2022-09-01 through 2022-09-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!