Duo Zhang comments

Results 364 comments of


                                            Duo Zhang

HBASE-29742 Compaction scan returns single cells instead of rows after 10MB

And I can not recall why block size should not be cleared... Need to do git blame...

HBASE-29742 Compaction scan returns single cells instead of rows after 10MB

Seems to be broken by HBASE-27558, where we introduce quotas for total block io for scans.

HBASE-29742 Compaction scan returns single cells instead of rows after 10MB

The spotless issues will be fixed by #7507. I think we'd better try to understand the code added in HBASE_27558, and see what is the correct way to fix this,...

HBASE-29742 Compaction scan returns single cells instead of rows after 10MB

Checked the code, the only place where we set keepProgress to true is in RegionScannerImpl.populateResult, where we want to keep progress across families, i.e, different StoreScanners. This is the keepProgress...

HBASE-29742 Compaction scan returns single cells instead of rows after 10MB

I've created a PR in #7562, where we clear the block progress after calling shipped. PTAL. Thanks.

HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259…

Ping @apurtell , do we need this on master?

HBASE-28957: Adding support for continuous Backup and Point-in-Time Recovery

I suggest we try the approach to not introduce the new 'ReplicationResult' concept to see if it could work before merging this back. Once the new concept is there, it...

HBASE-29672 Handle runtime comparison failures during filtering gracefully

Please fix the typo?

HBASE-29672 Handle runtime comparison failures during filtering gracefully

@droudnitsky Not all the copilot comments need to be addressed... Let me take a look again.

HBASE-29726 Allow updating time limit on ScannerContext

Could you please describe more on why and how Phoenix plan to control the time limit? Thanks.