Anislav Atanasov

Results 15 comments of Anislav Atanasov

I think that this pull request could be closed as this issue was handled in the following commit: https://github.com/tschellenbach/Stream-Framework/commit/1537cf89348d2ae6f46a54887db87996b086e6b1

I found exactly the same issue some time ago but I did not have time to fix it so far.

I agree that the implementation of the serialization_id is misleading. Probably, it is not fixed so far due to backwards compatibility. Here is the implementation that I use: ``` from...

From my point of view it is a problem with the activity serializer or storage. Do you set activity_storage_class or activity_serializer?

I think I found what causes the defect. Although, [AggregatedActivitySerializer](https://github.com/tschellenbach/Stream-Framework/blob/master/stream_framework/serializers/aggregated_activity_serializer.py) is initialized with activity_class, it does not pass it to the ActivitySerializer that is actually used to serialize and deserialize...

Hello, I added this method in order to address the following issue: https://github.com/tschellenbach/Stream-Framework/pull/75 Now I see that it is a bit confusing. Anyway, I think that right now there is...

Hi, I have just implemented NotificationAggregator class and it was merged to the master branch last week. Note that it is a work in progress and it is not part...

In case you are providing the item id as a target of the activity, you can go with an implementation like this one: ``` class NotificationAggregator(RecentVerbAggregator): def get_group(self, activity): verb...

You should implement the aggregation according to your project's requirements. From my point of view, Facebook has (or used to have) grouping based on the date.

This has been recently implemented and committed in the master branch. Anyway, the work is in progress, the documentation is not updated and the code is not available on PyPI.