Stream-Framework icon indicating copy to clipboard operation
Stream-Framework copied to clipboard

BaseFeed's add_many()

Open andrewjburnett opened this issue 9 years ago • 1 comments

From the source code it seems as though the add_many() function located within BaseFeed does not return the count of items added, even though this is what one would be led to believe by the use of the 'add_count' variable in the current source code.

Rather, it returns a list whose length and elements correspond to the number of score/value pairs added to the sorted set for each separate zadd operation performed with the sorted_set structure being used.

Am I wrong? If not, I think the 'add_count' variable should be renamed to something more representative of what is actually being returned by add_many().

The same applies to del_count in BaseFeed's remove_many().

andrewjburnett avatar Mar 19 '15 02:03 andrewjburnett

I found exactly the same issue some time ago but I did not have time to fix it so far.

Anislav avatar Apr 08 '15 19:04 Anislav