Andy

Results 8 comments of Andy

Admin managing account requests: use spinners to indicate actions in progress

Hey Ceaseless04, Here is a spinner example on the Edit Course Details page for instructors. https://github.com/TEAMMATES/teammates/assets/128531452/3a10b4f5-5341-460b-94c4-f61f4727d15a

Admin managing account requests: use spinners to indicate actions in progress

@Ceaseless04 any updates on this issue?

Vertical polyline shapes are difficult to select and move

I would like to give this a go. ### I can reproduce the issue 2 point polylines, in any direction: I have to place my mouse exactly on the polyline...

[#13102] Admin rejecting account request: give actual account in the email template

Changed the missing googleId string from "GOOGLEID NOT FOUND" to "NO_GOOGLEID" as its shorter and the underscores makes it more obvious. Added two tests for setting the existingAccount googleId when...

[#13066] Combine Admin Add Account Request Flow into Instructor Account Request Flow

@mingyuanc Yes this PR is done, if there's anything else that could be added, let me know, thanks.

[#13066] Combine Admin Add Account Request Flow into Instructor Account Request Flow

@domoberzin Mostly ready for review. I need help with the `accountCreateRequest` loop, I'm don't know how to call `fetchAccountRequests` and push to `invalidLines` only after all request have been processed....

[#13066] Combine Admin Add Account Request Flow into Instructor Account Request Flow

Sorry for the late update. The previously failing test in InstructorNotificationsPageE2ETest might be unrelated. I rewrote `validateAndAddInstructorDetails()` to use promises so that `fetchAccountRequests()` is only called once. The component tests...

[#13066] Combine Admin Add Account Request Flow into Instructor Account Request Flow

@mingyuanc Ready for review. The failing test - `UUID string too large` under `SearchAccountRequestsActionTest` line 959 seems unrelated, the same tests fail under the current master branch.