TEAMMATES
[#13066] Combine Admin Add Account Request Flow into Instructor Account Request Flow
Fixes #13066
Outline of Solution The "Add Instructor" and "Add Instructors" buttons now create account requests and pushes them to accountReqs for account-request-table to manage.
Removed the results table, some related functions and tests. Changed remaining tests to reflect the changes.
Adding, removing and editing is now handled by account-request-table.
https://github.com/TEAMMATES/teammates/assets/128531452/9fae443c-8d5c-4e0a-9f9c-1e93f9508162
Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...
Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...
Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...
Folks, This PR seems to be stalling (no activities for the past 9 days). :snail: :cry: Hope someone can get it to move forward again soon...
Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...
@Andy-W-Developer is the PR done? or isit still on going. Your current changes LGTM
@mingyuanc Yes this PR is done, if there's anything else that could be added, let me know, thanks.
@domoberzin Mostly ready for review.
I need help with the accountCreateRequest loop, I'm don't know how to call fetchAccountRequests and push to invalidLines only after all request have been processed.
I've tried looking into finalize but don't think it'll work unless createAccountRequest or an alternative supports a list of account requests.
A less than ideal way could be to move the account requests into a separate list and for loop then have an if statement inside createAccountRequests to check if the loop index is equal to the list length and run fetchAccountRequests there.
Let me know your thoughts, thanks.
@Andy-W-Developer could you look into why the SQL tests are failing first before we review?
Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...
Sorry for the late update.
The previously failing test in InstructorNotificationsPageE2ETest might be unrelated.
I rewrote validateAndAddInstructorDetails() to use promises so that fetchAccountRequests() is only called once.
The component tests are failing because changes to instructorDetails are made inside the subscribe, and createAccountRequest() isn't mocked yet.
I'm looking into why, after mocking the observables, the code inside the subscribe doesn't seem to run or only partially run.
Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...
@mingyuanc Ready for review.
The failing test - UUID string too large under SearchAccountRequestsActionTest line 959 seems unrelated, the same tests fail under the current master branch.
Folks, This PR seems to be stalling (no activities for the past 9 days). :snail: :cry: Hope someone can get it to move forward again soon...