Robin Richtsfeld

Undefined offset: -1 in TokenStream.php

11

Composer Version: `v4.10.5` ``` PHP Notice: Undefined offset: -1 in ./vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 205 ```

Fixes crash on launch on Linux: ``` [FATAL:double_fork_and_exec.cc(131)] execv .local-chromium/Linux-970485/chrome-linux/chrome_crashpad_handler: Permission denied (13) ``` See #1774

`LaunchOptions.EnqueueAsyncMessages` docs suggest it's true by default while it isn't

10

See the first line: ```xml Affects how responses to are returned to the caller. If true (default), the response is delivered to the caller on its own thread; otherwise, the...

See #1666, https://ci.appveyor.com/project/kblok/puppeteer-sharp/builds/38411956/job/j79vsdh2ngqo9gti/messages

Flaky Request Interception Test

1

https://ci.appveyor.com/project/kblok/puppeteer-sharp-esipd/builds/38253156#L269 ``` [xUnit.net 00:04:49.14] PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests [FAIL] Failed PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests [60 ms] Error Message: Assert.Equal() Failure Expected: String[] ["11", "FAILED", "22"] Actual: String[] ["22", "FAILED", "11"] Stack Trace: at PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests() in /home/appveyor/projects/puppeteer-sharp-esipd/lib/PuppeteerSharp.Tests/NetworkTests/SetRequestInterceptionTests.cs:line...

Clean libexec

3

Argument mixes string and array. Use `*` or separate argument. Double quote array expansions, otherwise they're like `$*` and break on spaces. Assigning an array to a string! Assign as...

Clean extensions and sampleapps

3

Double quote array expansions, otherwise they're like `$*` and break on spaces. Don't use `[]` around ranges in `tr`, it replaces literal square brackets.

Clean bdutil

3

Argument mixes string and array. Use `*` or separate argument. Double quote array expansions, otherwise they're like `$*` and break on spaces. Assigning an array to a string! Assign as...

Move bookmarks on changes to line numbers

29

Fixes #137 @aaxu /cc

As suggested by static analysis tool: https://github.com/koalaman/shellcheck/wiki/SC2006 https://github.com/koalaman/shellcheck/wiki/SC2164 https://github.com/koalaman/shellcheck/wiki/SC2166