puppeteer-sharp icon indicating copy to clipboard operation
puppeteer-sharp copied to clipboard

Flaky Request Interception Test

Open Androbin opened this issue 4 years ago • 1 comments

https://ci.appveyor.com/project/kblok/puppeteer-sharp-esipd/builds/38253156#L269

[xUnit.net 00:04:49.14]     PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests [FAIL]
  Failed PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests [60 ms]
  Error Message:
   Assert.Equal() Failure
Expected: String[] ["11", "FAILED", "22"]
Actual:   String[] ["22", "FAILED", "11"]
  Stack Trace:
     at PuppeteerSharp.Tests.NetworkTests.SetRequestInterceptionTests.ShouldWorkWithEqualRequests() in /home/appveyor/projects/puppeteer-sharp-esipd/lib/PuppeteerSharp.Tests/NetworkTests/SetRequestInterceptionTests.cs:line 435
--- End of stack trace from previous location where exception was thrown ---

See https://github.com/hardkoded/puppeteer-sharp/pull/1648#issuecomment-800577000

It's unclear where the underlying bug is, in the unit test, in Puppeteer (Sharp), or in Chromium.

Androbin avatar Mar 16 '21 21:03 Androbin

I have found the upstream PR that originally introduced the new interception API and tests: https://github.com/puppeteer/puppeteer/pull/242

Androbin avatar Mar 16 '21 22:03 Androbin