Andrew Kushnir

Results 312 comments of Andrew Kushnir

There is no progress on this change yet. The problem is that the code introduces the use of the `ViewChild` decorator, which was not present before in the Router package....

This PR was merged into the repository by commit f8e51194355914fb766bfe9bd0aca047bc7ac7b3. The changes were merged into the following branches: main

> we should consider formatting 19.0.x as well just to reduce conflicts in future PRs that target patch. +1, that'd be great to have a version of this change for...

This PR was merged into the repository by commit b7ab5fa2562524a0e8dfa4f3dff740ec2d31b4c7. The changes were merged into the following branches: main

@JeanMeche you are right, thanks 👍 I've updated the title and the description of the ticket to improve the error message to make it more actionable.

Adding the "ai" label, since the original code that was causing the issue was generated by an LLM. Having a better error message should increase the likelihood of a successful...

@manbearwiz we've reverted this change via https://github.com/angular/angular/pull/59544, since it broke some targets in Google's codebase. We'll be running some additional tests and let you know what the next steps for...

[Global presubmit](https://test.corp.google.com/OCL:716065491:BASE:716065323:1737003470562:fe74ca0b).

@manbearwiz thanks for additional info. I've looked at the broken targets internally and found out that the diagnostic correctly identified cases when directives were not imported, but used in templates....

**Caretaker note**: the `test` CI job failure is unrelated to this change and will be resolved via https://github.com/angular/angular/pull/57986. This PR is ready for merge.