Andrew Schofield

@JimmyWang6 Please merge latest changes. Now that https://github.com/apache/kafka/pull/20049 is merged, the `Admin.alterShareGroupOffsets` will now return top-level errors correctly. This means `kafka-share-groups.sh --reset-offsets` in error cases will fail, rather than appearing...

Thanks for the updates. I'm starting to review and test it. Here's a small problem I've found so far. `SG1` is an existing share group with 1 member. `T2` doesn't...

Please fix the checkstyle build error.

Still getting the usage message for trying to reset offsets for a consumer group. ``` bin/kafka-share-groups.sh --bootstrap-server localhost:9092 --reset-offsets --group CG1 --topic T1 --execute --to-earliest Group CG1 is not a...

Please also merge latest changes from trunk. I expect the build will be clean afterwards.

> Thanks for the PR. Since this changes the public interface/behavior of this tool, it requires a KIP, and I already have one (https://cwiki.apache.org/confluence/display/KAFKA/KIP-1137%3A+Standardize+Property+Loading+Priority). So we need to wait for...

@Yunyung I certainly will review the KIP but probably not until after the 4.2 feature freeze.

@vinupreethi Could you explain the purpose of this patch please?

@lianetm @FrankYang0529 I have opened https://issues.apache.org/jira/browse/KAFKA-18220 to track any refactoring to this to improve the code structure where we want to use this for both the AsyncKafkaConsumer and ShareConsumerImpl. I'm...

@lianetm @kirktrue The direction this PR is heading in looks good to me. Please could you take a deeper look and see whether you agree.