Andrew Schofield

Results 30 comments of Andrew Schofield

The connector just uses a regular JMS client. Just follow the MQ documentation for a bindings-mode JMS application and it will work.

Hi. The connector doesn't give you a way to work with the JNDI context factory directly. I don't have an "MQ admin team" so I didn't think of this use...

Hi. Thanks for raising the issue. I think this is a bug, but your proposed fix is not better. It does ensure that the connection is closed in your specific...

Yes. A synchronised way of doing it will work. This complexity is because the state machine for source connectors is rather weak at the moment. I did open a Kafka...

The `reader.receive()` will block indefinitely for the first message in a batch. This means, the `stop()` method could also block indefinitely.

I think I would be looking to call `reader.close()` in the `poll()` method. This is tricky because the code is also trying to minimise the amount of message duplication when...

Of course, what is really needed is KIP-419. Then the code would include the "missing" `reader.close()` in the `stopped()` method as a final clean up.

You've definitely found a bug, but it's really hard to test this because the overlapping and interleaving of calls to `poll()` and `stop()` is undefined. I have even seen a...

Thanks for the PR. I have made the same changes under a much wider review of the OpenAPI spec so this PR is no longer required.

For a modern Kafka producer, the default is to enable idempotence. The REST Proxy does not support transactions.