KAFKA-2526: command line --producer-property wins

[jkt628]

apply --producer-property settings last to override any, including default, values.

tested manually with value.serializer. the extant test for client.id is unaffected.

Committer Checklist (excluded from commit message)

• [ ] Verify design and implementation
• [ ] Verify test coverage and CI build status
• [ ] Verify documentation (including upgrade notes)

[jkt628]

test failures seem very much UNRELATED to this change.

[github-actions[bot]]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[jkt628]

unstale

[jkt628]

./gradlew clients:test -PmaxParallelForks=2 passes but i cannot run the full suite due to OOM.

[github-actions[bot]]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[jkt628]

unstale

[jkt628]

note test for client.id moved to https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/ConsoleProducerTest.java

[github-actions[bot]]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[jkt628]

unstale

[jkt628]

note parameters changed to --command-config and --command-property

[jkt628]

@AndrewJSchofield @Yunyung would you please review?

[Yunyung]

Thanks for the PR. Since this changes the public interface/behavior of this tool, it requires a KIP, and I already have one (https://cwiki.apache.org/confluence/display/KAFKA/KIP-1137%3A+Standardize+Property+Loading+Priority). So we need to wait for this KIP to pass.

[AndrewJSchofield]

Thanks for the PR. Since this changes the public interface/behavior of this tool, it requires a KIP, and I already have one (https://cwiki.apache.org/confluence/display/KAFKA/KIP-1137%3A+Standardize+Property+Loading+Priority). So we need to wait for this KIP to pass.

I think that KIP could do with a bit of encouragement.

[Yunyung]

@AndrewJSchofield Thanks! The KIP felt encouraged and decided to make its debut :) I'd appreciate your review and feedback. Discussion thread: https://lists.apache.org/thread/vlqvcyl5j95t7w9rk3nnz09d0050yzh9

@jkt628 I will create a Jira Umbrella for this KIP once it is voted on and passed. Feel free to pick up some of the tasks.

[AndrewJSchofield]

@Yunyung I certainly will review the KIP but probably not until after the 4.2 feature freeze.