Andreas Borgen Longva

Results 238 comments of Andreas Borgen Longva

There are several issues here, and I'm not quite sure if we can really resolve them. Most of these methods, such as `column` are methods on the very generic `Matrix`...

> Hello there, any news on this ? What kind of news are you looking for? I don't think `.into_vec` or similar has been implemented (and I'm not sure if...

Yes, you're right. This is implemented in #1232, but currently helped up by some unresolved questions.

Good catch. We should probably make it panic, since it's likely a mistake by the user if it doesn't fit, and if it's not the user can simply call `.take(n)`...

After looking at the PR (which looks great btw!) I'm a little bit uncertain about my previous statement. It might break some user's code (though should be easy to fix...

Yeah, in any case we should fix the problem of iterators running indefinitely, and make the behavior consistent :+1:

Thanks for your input @sebcrozet. I agree with that for the vector case, but the matrix case is what's troubling me. I can't imagine a single case where I'd legitimately...

Some comments from an `rstar` user who's not so familiar with the `rstar` code base itself: From a user's perspective, I think this is probably a good idea. It reduces...

Oh, and, perhaps you consider *not* implementing `Copy` for `Params`, since you might want to add non-copy settings in the future. The amount of times you need to explicitly `.clone()`...

This appears to be a failure of `assert_view_index` to take into account `usize` overflow, here: https://github.com/dimforge/nalgebra/blob/48c8f6a5053fac48e305f5e5e0004a332811d092/src/base/matrix_view.rs#L280