Arkadiusz Lachowicz

Results 27 issues of Arkadiusz Lachowicz

TODOs: - fix https://github.com/Devsh-Graphics-Programming/Nabla/blob/window_resizing/include/nbl/ui/CWindowAndroid.h#L33 otherwise it crashes when `getManager` is invoked - better class hermetization, why we have stuff that should not be available by user placed in public section?

bug
help wanted
good first issue

![image](https://user-images.githubusercontent.com/34793522/124909287-90d2af80-dfea-11eb-97ec-a911b27b2b17.png) We need to adjust CMake code to be able to build out of source tree, where `${CMAKE_BINARY_DIR}` isn't placed in `${CMAKE_SOURCE_DIR}` because it leads to erros.

bug
CMake

### TODO - use CMake to add appropriate POSTFIX according to config Some libraries don't have adjusted postfixes to the config and it may lead to helll when using Nabla...

bug
CMake

We may encounter the lack of proper windows symbolic permissions issue, some submodules may requesting them like `zstd` on clang for instance. The following note should be included in readme...

enhancement
README

I found with @sadiuk we should make sure our build system and the 3rdparties switches to correct ASM through _if statements_ and not let find it automatically, because it may...

bug

Provide common utility that both glTF and MTL loader can use for caching on-demand image views https://github.com/Devsh-Graphics-Programming/Nabla/commit/8280d5d2d8918cad21f37f424831f5996b3be86c#r60379137 https://github.com/Devsh-Graphics-Programming/Nabla/pull/269#discussion_r753661092

enhancement

it may lead to unstable behaviours on certain CMake versions, just see https://github.com/Devsh-Graphics-Programming/Nabla/blob/criss_baw/cmake/common.cmake#L309 We should not have changed variables that are only being used for reading target property, e.g. `TARGET_NAME`...

bug
CMake

then have a declaration of the functions in `core/decl/math/floatutil.h` and the definition in `core/def/math/floatutil.h` like other templates _Originally posted by @devshgraphicsprogramming in https://github.com/Devsh-Graphics-Programming/Nabla/pull/205#discussion_r702157783_

enhancement
help wanted
good first issue

Nabla uses many variables referencing to the top level of the source tree, it should not be done this way and if we would like to see Nabla building without...

bug
CMake

https://github.com/libLAS/libLAS/blob/master/apps/CMakeLists.txt#L63 this line makes it impossible to attach the project as submodule since it refers to top project, I would change `${CMAKE_SOURCE_DIR}` to `../`

enhancement
build