Correction to CMAKE

Open AnastaZIuk opened this issue 5 years ago • 2 comments

https://github.com/libLAS/libLAS/blob/master/apps/CMakeLists.txt#L63 this line makes it impossible to attach the project as submodule since it refers to top project, I would change ${CMAKE_SOURCE_DIR} to ../

Dec 10 '20 13:12 AnastaZIuk

Feel free to submit a PR.

It may be better to consider CMAKE_CURRENT_SOURCE_DIR

Dec 10 '20 16:12 mloskot

Yeah, actually it is still possible to workaround it by using external project, but not by using subdirectory

Dec 12 '20 09:12 AnastaZIuk