Hadrien Croubois

Documentation of events emitted by functions

1

Currently, we require the natspec comment of each function to include details of events emitted by this function. Some cases are however not that simple and need to be clarified:...

Meta Issue: Planned breaking changes for new major (5.0)

1

Here is a list of breaking changes that we would like to include in the next major release. Timming for this release is not yet known. - https://github.com/OpenZeppelin/openzeppelin-contracts/issues/2839 - #2962...

[5.0.0 Breaking change] Using user defined value type for timers

3

The structures used in the timers library prevent storage packing (in particular, this affects Governor's Proposals). This has to effect that makes it a breaking change: - Storage incompatibility (data...

Extend MerkleProof with notion of index for unsorted trees or leaf identifiers

6

@k06a proposed an implementation for this feature in #2815. A related feature was proposed in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2851 to compute a leaf identifier when a proof is validated, that could be used...

Allow custome maxPriorityFeePerGas in hardhat.config.js (@hardhat/ethers)

5

Ethers.js provider usually inherits from the `abstract-provider` class. This class includes a `getFeeData()` function, which sets the maxPriorityFeePerGas to 2.5gwei at the provider level. This can be overridden to change...

unsupported methods fails violently

2

I noticed that some methods are not available. In particular: - eth_chainId - personal_sign - eth_signTypedData_v3 While I understand that not all methods are implemented (chainId is a shame, as...

web3provider has no `.on()` endpoint

2

web3.on is commonly used by frontend to adapt to wallet events. It not being avaialble on walletlink breaks a lot of assumption dapps usually have about providers.

Add option to make output "markdown compatible"

1

The report table, while it looks like markdown, is not markdown. I believe it would be very nice to be able to display report either in github or through modia...

is `encodeRouteToPath` second param really `exactOutput` ?

1

Hello, Lets start by the contract I'm writing. It is supposed to swap arbitrary user token to the one my system uses, before actually doing stuff. ``` function deposit(address receiver,...

Fixes https://github.com/OpenZeppelin/contracts-wizard/issues/70 ERC721 - [ ] Decide on design (default, per token, both?) - [ ] Fee denominator? - [ ] Implement core - [ ] Implement UI ERC1155 -...