Hadrien Croubois
Hadrien Croubois
By default, the `Governor` is designed to be its own executor. That means any proposal's action will be executed from the Governor itself. By default, proposals that are succesfull can...
Fixes #7759 for v2 Based on #7753. - [x] Because this PR includes a **new feature**, the change was previously discussed on an Issue or with someone from the team....
### Version of Hardhat 2.27.1 ### What happened? Using - "hardhat": "^2.27.1" - setting evm version to osaka Whenever doing a operation (deploying a contract, sending a transaction, performing a...
This PR also changes the way imports are written, consolidating multiple items are imported from the same file. This changes the way imports are ordered (by path instead of by...
As written on the solmate readme.md: > Solmate is no longer actively maintained. [Solady](https://github.com/Vectorized/solady) has effectively succeeded the project.
In the benchmark markdown files, the table are missing the first collumn. For example in ```markdown | Implementation | allowance | approve | balanceOf | deploy | totalSupply | transferFromToNonOwner...
In Diamond.sol, the receive function is implemented and does nothing. It currently does not delegate to any facet https://github.com/mudgen/diamond-1-hardhat/blob/3da037b378195b4108b977cf2014600eeddbf67d/contracts/Diamond.sol#L71 This is bad. It means all diamon proxy accept receiveing eth,...
TODO: - Is there an issue with the `/// @custom:storage-location erc7201:${id}` annotation being invalid if the function is overriden ? How do we deal with that ?