Vitaly Terentyev

Results 67 comments of Vitaly Terentyev

> @Amar3tto can we add a comment in CHANGES.md calling out this new feature? Done

There are some difficulties in supporting UDFs with `@Parameter(...) Row` and `@Parameter(...) Predicate1`: 1. Each parameter type should be [translatable](https://github.com/apache/beam/blob/90d3f8a177ff935a09852fd85892bb1399b85c91/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java#L340) to Calcite `RelDataType`. 2. If we want to translate `Row`...

`PubSubMessage` naming will be not consistent, because: 1. We have `PubsubIO` and other classes (not `PubSubIO`) 2. `com.google.pubsub.v1` has `PubsubMessage` class. `PubsubMessage` naming also wouldn't be consistent, because: 1. `com.google.cloud.pubsublite.proto`...

Can this issue be closed or is there something else left?

I tested locally different queries and here are the results. I guess `total` and `avg1`, `avg2` columns are somehow related and together lead to an error in certain cases. Successful:...

Note: fix UI for the KMS_KEY_NAME parameter before merging this PR