beam icon indicating copy to clipboard operation
beam copied to clipboard

Support withFormatRecordOnFailureFunction() for BigQuery STORAGE_WRITE_API and STORAGE_API_AT_LEAST_ONCE methods

Open Amar3tto opened this issue 1 year ago • 3 comments

Fixes #31354


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Amar3tto avatar Jun 20 '24 10:06 Amar3tto

R: @Abacn

Amar3tto avatar Jun 20 '24 13:06 Amar3tto

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jun 20 '24 13:06 github-actions[bot]

R: @sarinasij FYI one can follow https://github.com/apache/beam/blob/master/contributor-docs/code-change-guide.md#run-your-pipeline-with-modified-beam-code to test this PR with your use case

Abacn avatar Jun 20 '24 18:06 Abacn

R: @ahmedabu98

Amar3tto avatar Jul 11 '24 15:07 Amar3tto

@Abacn Could you please help with the review process?

Amar3tto avatar Jul 12 '24 14:07 Amar3tto

Didn't get a chance to go through the change. I see the author of the FR @sarinasij is responsive. Would it be possible for you testing the change with your use case, to see if this unblocks you?

Abacn avatar Jul 12 '24 16:07 Abacn

@ahmedabu98 Could you please review?

Amar3tto avatar Aug 05 '24 09:08 Amar3tto

CC @johnjcasey @AnandInguva I believe this does what y'all wanted to do in #31106

ahmedabu98 avatar Aug 06 '24 15:08 ahmedabu98

@Amar3tto can we add a comment in CHANGES.md calling out this new feature?

ahmedabu98 avatar Aug 08 '24 16:08 ahmedabu98

@Amar3tto can we add a comment in CHANGES.md calling out this new feature?

Done

Amar3tto avatar Aug 12 '24 17:08 Amar3tto

Run Java_GCP_IO_Direct PreCommit

Amar3tto avatar Aug 12 '24 18:08 Amar3tto