beam icon indicating copy to clipboard operation
beam copied to clipboard

[Bug]: PubsubMessage should be renamed to PubSubMessage to reduce confusion

Open aaltay opened this issue 3 years ago • 1 comments

What happened?

Beam has PubsubMessage PubSubMessage PubsubMessages. The use is inconsistent and confusing. It would be good to use a standard naming scheme. (PubSubMessage seems to be the correct version based on the product name.)

This might require a breaking change, and if that it is the case we might need to hold on until the next major version.

Issue Priority

Priority: 3

Issue Component

Component: io-java-gcp

aaltay avatar Aug 03 '22 19:08 aaltay

PubSubMessage naming will be not consistent, because:

  1. We have PubsubIO and other classes (not PubSubIO)
  2. com.google.pubsub.v1 has PubsubMessage class.

PubsubMessage naming also wouldn't be consistent, because:

  1. com.google.cloud.pubsublite.proto has PubSubMessage
  2. RunnerApi has PubSubReadPayload and other classes

Amar3tto avatar Jun 24 '24 07:06 Amar3tto

FYI @aaltay

Amar3tto avatar Jul 09 '24 19:07 Amar3tto

Thank you for the analysis @Amar3tto. I think this is still an inconsistency and an issue. But I understand your point, it may not be feasible to address this. In that case we can close this as won't fix / infeasible.

aaltay avatar Jul 09 '24 20:07 aaltay