Almas Baim

Results 163 comments of Almas Baim

Thanks for this. I agree with non-core JavaFX dependencies not being inside `kit`. There is a future plan for `plugins`, (seems to be called components in this PR, but I...

Initial steps to be implemented as part of #458

@Oliver-Loeffler I've only skimmed through this, but I was wondering if you can split this into multiple smaller PRs: one for tests, one for production code change, one for refactor,...

@jperedadnr could you point me to where I would get the `TabPane` from (I assume there is some scene graph object)?

``` if (fxomObject.getParentObject().getSceneGraphObject() instanceof TabPane) { TabPane tabPane = (TabPane) fxomObject.getParentObject().getSceneGraphObject(); tabPane.getSelectionModel().select((Tab) sceneGraphObject); } ``` solves the NPE, but I don't know where to start on the selection issue

Thanks... if this is still an issue for you, please could you provide the actual steps to reproduce.

@Oliver-Loeffler I've seen some menu bar related code that seems to do something specific on Mac OS. Is this issue still relevant?

Now that we identified this is a valid issue, I suppose the question is whether we actually wish to support it and if yes, whether the work required is justified...

Not a short-term goal but adding this here so ideas can be generated over time. In addition, creates a space for users and developers to keep track of the development...

If I understand correctly, based on issues and open PRs, the idea is that SB _ships_ with these custom controls, available for use out of the box, without imports. On...