John Gardner

Shouldn't be necessary forever, but that's up to the Atom team. :p

PRs merged! Gonna enjoy fixing this... @50Wliu, you mightn't see *that* much of a speed improvement if you're running a recent build of Atom. But the plan is to make...

@aminya During loading, the package has to run almost [2,000 regular expressions](https://github.com/file-icons/atom/blob/master/lib/icons/.icondb.js) against every filename that's visible in the workspace. It's already memoising each result to reduce overhead, *and* the...

Yes, it's pure JavaScript.

What's your point, exactly?

I don't know what algorithms V8 uses for its regular expression matching. It's probably a hybrid of several. Regardless, it's not something I have control over. 150ms versus 15ms is...

FYI, the execution speed is tangential to the problem reported in this thread. Matching doesn't happen until after `file-icons` has loaded and activated, and package activation happens on a blocking...

@isiahmeadows I'm in the same boat with an ancient MacBook and an equally ancient Dell laptop with almost non-existent battery life (both have low-density screens too, which seriously sucks when...

> Well, it is 10X speed up. This is a huge improvement for me. And you're suggesting we add a hard dependency on a runtime library that we actually don't...

Slight correction: it only explains *some* of its performance issues. Package code *can* use native add-ons, but doing so requires extra tooling that users may or may not have available....