John Gardner

Results 228 comments of John Gardner

Done. Hopefully this'll make Harvester's rewrite less intimidating. πŸ˜…

I've been tempted to add support for AdBlock filters in the past. I decided against it for two reasons: 1. We're disambiguating against freeform text, which should be assumed to...

> but the .adblock extension is rarely used No, I'm not talking about the `.adblock` extension. I'm referring to the use of `.txt` for storing AdBlock filter rules (which currently...

> It is enough to examine only the beginning of the txt files. No, it isn't. For a start, an Adblock filter list can begin with a comment or a...

@lildude This LGTM, from my own testing. πŸ‘ You might have access to a larger corpora of `.txt` files with which to test the heuristic, though. πŸ˜‰

Nah mate, you did most of the heavy-lifting. πŸ˜‰ If anything, we should be thanking you.

> This adds a workflow that runs an adapted version of "Harvester" Which parts were adapted, exactly? I don't recognise anything that resembles my own code… Anyway, you might be...

Reporting extension usage is the primary use-case for the tool, and I plan on having an option to select output formats (markdown for GitHub discussion copy+pasta, null- or tab-separated values...

> In [languages.yml#L2000-L2019](https://github.com/github/linguist/blob/47b109be3657fe3d5933fba6840a6ceea0f94498/lib/linguist/languages.yml#L2000-L2019) i don't see any mentioning of the extensions `.mjs` and `.esm`. That's because you're looking at a long-outdated revision of `languages.yml`. The [current version](https://github.com/github/linguist/blob/4ffcdbcbb60a74cbfbd37656bcc3fcea4eca8e26/lib/linguist/languages.yml#L3015) lists `.mjs` as...

It's actually *not* shell. I [wrote a grammar](https://github.com/Alhadis/language-etc/commit/7d9e4f8704ceeadd244b21eeb7ac69a9b2405f8b) for `dotenv` files quite recently, and was surprised by the number of syntactic discrepancies (particularly its wacky handling of quotes). Because `FOO...