Christopher Mahoney
Christopher Mahoney
> This should update code to use new Java 17 features I can do that. I'm familiar with instanceof pattern matching and new switch syntax. Are there other things I...
@spacey-sooty You're just too fast! I copy pasted the wrong permalink. https://github.com/Alextopher/photonvision/blob/f4e2d4b3bef7a707fd156c8b7cd68f7ce251cd75/photon-docs/build.gradle#L250 This looks like a hack - does JDK 17 just _fix_ this? RE @mcm001 #1094
Upstream - https://github.com/wpilibsuite/allwpilib/pull/7007
@mcm001 do you think you could make a sequence diagram of this protocol?
I've been dragging my feet on writing an RFC on these types. I'm a bit concerned with how `Request` doesn't follow typical ownership and borrowing rules (you only need a...
The problem I see with my suggestion: it's a lot of breaking changes. However, I think it makes the library more mature and idiomatic and opens up more features that...
#335 my current draft
I think methods that consume the body should capture ownership over self, reading the body twice (without cloning) is almost always bug. But you're right my mutability concerns are mostly...
I see that, I think there's a tradeoff: Do we want this signature (which makes the returned value immutable) ```rust pub fn integrity(&self) -> &String { &self.options.integrity } ``` Or...
> Re: the duplicated reading, I think this is a matter of preference. I agree if the body was its own struct then reading it should take ownership but there...