Alexander Yastrebov
Alexander Yastrebov
> maybe we should pass the pool size per filter We have reserved parameter names starting with "lua-" [documented](https://github.com/zalando/skipper/blob/master/docs/reference/scripts.md#route-filters) > Any parameter starting with "lua-" should not be used to...
> log access format should be using named interpolation like the one I added to eskip/template This was unified across filters as https://github.com/zalando/skipper/blob/master/docs/reference/filters.md#template-placeholders and can be reused for access log...
Another thing not mentioned is whether access log pattern should be customized globally or per route or both.
> do we need a prefix for the "type" like static or fixed I think the name should provide useful hints. Single argument implies constant delay so IMO `static` or...
> I suggest to slightly refactor ringShards type so we can fully replace it in SetAddrs holding the lock: This does not look to be safe for concurrent use: imagine...
As an idea we may have another mutex to guard only `SetAddrs` and `Close` (need to make sure to lock it first in both methods https://stackoverflow.com/questions/38489190/holding-two-mutex-locks-at-the-same-time). This way we ensure...
Hold on with update until we test it
> Hold on with update until we test it It should work though, please report if you test yourself