Results 224 comments of Alexander Yastrebov

Hi, > The problem here is that in case a user is no longer logged in (for any reason), oauthGrant filter will respond with a redirect to authenticate the user...

> Token revoked. What is the point of extracting it then? > The API call is coming from a headless client (i.e. the cookie is missing). The route technically can...

@szuecs Look from users perspective - they don't really want to (or even can not) know in depth all the details and implications of the setup especially when skipper is...

> Currently filters instantiated using a createFilter method can leak memory or other resources if they are requisitioned on creation and the corresponding route is consequently removed from a skipper...

The issue with such helpers (IMO) is that they tend to diverge from filter/predicate implementations as they evolve so I think their maintenance cost/value ratio should be carefully considered here....

Hi, thank you for the feature request, I'll add a couple of notes. Ingress properties (namespace, name, path, etc) used to construct route id are not preserved up to the...

> I would rather create symbolic filters, which can be used during converting the ingress objects, but also in free-form configuration. I think (not 100% sure though) Prometheus requires a...

> Should I move all code from dataclients/kubernetes/ingressv1.go to dataclients/kubernetes/ingress.go and rename the ugly V1 Suffixes everywhere? Not sure, but if yes it is better done in a separate changeset.