Results 224 comments of Alexander Yastrebov

Alternative could be to integrate with spring security and log `SecurityContextHolder.getContext().getAuthentication().getName()` to keep it auth-method agnostic.

It would be interesting to support JWKs ~url~ file as a key in the `jwt` tool.

IMO HS already works as expected: ```sh echo '{"foo":"bar"}' | jwt -alg HS512 -key

> and avoids unnecessary memory allocations Would it be possible to add a benchmark to demonstrate that change indeed reduces allocations?

Vote up! For now one could use this hack: ``` function setUserAgent(page, ua) { page.setFn('EVIL_EVAL', 'page.settings.userAgent = "' + ua + '"'); } ``` I think API should be more...

Some ideas * use child [`context.WithTimeout`](https://pkg.go.dev/context#WithTimeout) in the `PrepareForRemoval` and `doUpdate` * do cluster config update before nodepool updates https://github.com/zalando-incubator/cluster-lifecycle-manager/blob/769565ccaa59ba839fc127a0b907dd1687311617/provisioner/clusterpy.go#L424 * do not return early on pool update error https://github.com/zalando-incubator/cluster-lifecycle-manager/blob/769565ccaa59ba839fc127a0b907dd1687311617/provisioner/clusterpy.go#L400-L409...

I think it eventually logs how long it took to complete https://github.com/zalando-incubator/cluster-lifecycle-manager/blob/dc1763e69020c6fc1863816c1bdbb199381406f0/pkg/updatestrategy/drain.go#L387 which takes up to https://github.com/zalando-incubator/cluster-lifecycle-manager/blob/dc1763e69020c6fc1863816c1bdbb199381406f0/pkg/updatestrategy/drain.go#L420 I am not sure it makes sense to log the retry progress as...

> cheap/easy place to do HTTP redirects, which is what the ALB provides ALB for HTTP redirects is not cheap IMO :) Please also note that NLB (or rather existing...

> What is the preferred mechanism to define additional listeners and target groups Two target groups for NLB is quite a new feature (#435) currently configured with startup flags.

Maybe the best option would be to manage NLB outside of the controller by e.g. a separate Cloud Formation stack. We may think though to improve controller stack to export...