Alex Waygood

Results 901 comments of Alex Waygood

> Remove redundant test name Definitely. > File paths not clickable Huh, they're clickable for me in VSCode. But I definitely don't object to this change. > Reduce indentation >...

On earlier versions of Python, there were two different functions, `inspect.iscoroutinefunction` and `asyncio.coroutines.iscoroutinefunction`. This was confusing, because they did two different things: `inspect.iscoroutinefunction` was strict about only returning `True` for...

> The 3.13 test fails, because this hasn't been implemented in 3.13 yet. It should be fixed with 3.13.rc1. What's the best course of action? I'd add a decorator like...

Looks like you might have closed this accidentally. Probably this is something to do with the fact that it was a PR from your fork's `main` branch. I think it's...

We've all been there, pretty sure I've done it at least once :-)

Fixed in https://github.com/python/cpython/commit/e28477f214276db941e715eebc8cdfb96c1207d9, I believe (please reopen if I'm incorrect!)

I think these are all fixed now, and we now run Python 3.14 in CI. Please open a new issue if there are any other test failures!

> It would be great to see it also implemented in mypy and the other major type checkers so we could start to use the new features in type stubs....

> > Note that PEP 695 support is currently behind this feature flags, since it's not complete yet: `--enable-incomplete-feature=NewGenericSyntax` > > ``` > $ mypy --enable-incomplete-feature=NewGenericSyntax . > usage: mypy...