Alex Waygood

Results 902 comments of Alex Waygood

> Isn't there a way in Ruff to specify extra globals/builtins ? https://docs.astral.sh/ruff/settings/#builtins ?

I really like the idea of having a `py:deco:` role for marking up decorators. There's _lots_ of docs PRs I would have used this on in the past; I think...

> @AlexWaygood Is my understanding correct that red knot's inference for `from import` misses the automatic sub-module fallback? Yeah, I _think_ that's a known limitation of the red-knot semantic model...

The relevant TODOs in red-knot are this comment and these currently-skipped tests. I think we'd fix this in the red-knot semantic model rather than the red-knot module resolver, however, so...

I like this idea overall, but I think it would be good to exclude docs-only PRs from this check. > If a review if performed and new commits are added,...

Note that we already run `test_typing` after `typing_extensions` has been installed, but that's not as comprehensive as what's being proposed here: https://github.com/python/typing_extensions/blob/44de568f73a93f29e52c2fc2d5f149305a4a3bae/.github/workflows/ci.yml#L74-L81

> Implementation idea: If a default follows the pattern `([\w.]+)\.\w`, check whether the type includes the first match group. We might need something a little cleverer -- I think this...

The covdefaults coverage plugin might be useful for us. It allows you to suppress coverage calculations on a version branch only if you're running a specific Python version: https://github.com/asottile/covdefaults?tab=readme-ov-file#version-specific--pragma-no-cover

This has been merged into the `ruff-0.8` branch; it will land in the next release (Ruff 0.8)