Alex Waygood
Alex Waygood
My feeling is that the new behaviour is probably correct. Calling `isinstance()` and `issubclass()` against a protocol that isn't decorated with `@runtime_checkable` isn't usually allowed, but we make an explicit...
> However, it seems wrong that singledispatch allows dispatching on a non-runtime checkable protocol. I tried locally and `test_functools` and `test_typing` both pass if I remove functools from `_allow_reckless_class_checks`. I...
Note that mypy already implements this rule with its `unused-awaitable` error code: https://mypy.readthedocs.io/en/stable/error_code_list2.html#check-that-awaitable-return-value-is-used-unused-awaitable. That doesn't stop ruff implementing it as well -- but I feel like it might be a...
> @AlexWaygood - I guess the rule as implemented here is actually a bit different (unclear if better or worse) than what's described in the Mypy docs, since this raises...
> e-running the failed job should now result in a green build here. I did so, and the build is indeed now green. Thanks @hugovk and @CAM-Gerlach!
> Is that acceptable? That seems fine to me! Thanks for checking!
I'd be willing to accept a fix for this, but it also sounds like the kind of thing that could lead to a big performance regression if done in a...
See https://github.com/python/cpython/issues/113313 for some previous discussion on this. Considering that `isinstance(deque(), MutableSequence)` evaluates to `True` at runtime, and that this is the only respect in which `deque` is not a...
Has this been superseded by #507?