websocket icon indicating copy to clipboard operation
websocket copied to clipboard

Accept https proxy

Open philipatl opened this issue 2 years ago • 7 comments

Fixes #739

Summary of Changes

  1. call proxy_RegisterDialerType for the https scheme to allow communication to https proxies
  2. some scheme-specific setup is necessary in Dialer's DialContext in order to use the TLSClientConfig
  3. add a UsesTLS method to the proxy_Dialer interface to ensure the https forwardDialer can inspect that https is supported, and to adjust if necessary

philipatl avatar Dec 03 '21 17:12 philipatl

I am not a maintainer of the project, but I do have some comments on the CL:

  • The CL modifies the generated file x_net_proxy.go. Avoid editing the file or regenerate the file if a new version of x/net/proxy has the desired functionality.
  • The CL is missing tests.

ghost avatar Dec 03 '21 19:12 ghost

I am not a maintainer of the project, but I do have some comments on the CL:

  • The CL modifies the generated file x_net_proxy.go. Avoid editing the file or regenerate the file if a new version of x/net/proxy has the desired functionality.
  • The CL is missing tests.

Thanks, I've made the suggested changes.

philipatl avatar Feb 17 '22 18:02 philipatl

Is there anything else needed here that prevents merging? Any comments? @garyburd

philipatl avatar Mar 04 '22 15:03 philipatl

It would be great to see https proxy support. Are there any open blockers or concerns that the community could help with this PR or an alternate implementation?

joemiller avatar Jul 20 '22 00:07 joemiller

Are there any open blockers or concerns that the community could help with this PR or an alternate implementation?

Almost every PR is blocked by a lack of an active maintainer.

kamikazechaser avatar Dec 06 '22 07:12 kamikazechaser

Why this PR wasn't merged?

tomerb-neosec avatar Nov 16 '23 10:11 tomerb-neosec

@tomerb-neosec it looks like there are merge conflicts in this PR. If you get those taken care of we can go forward with reviewing and getting this merged in. Thanks for your contribution!

AlexVulaj avatar Dec 07 '23 04:12 AlexVulaj