AlexIIL

Results 259 comments of AlexIIL

Hey, thanks for making this! However at the moment I'd rather gauge interest in this feature, rather than actually implement it directly - in particular this implementation works at the...

From a technical perspective this is fairly simple - mods *are* zip files, just with a different file extension (`.jar`). In addition, we already have lots of code for extracting...

Yes, dependency overrides haven't been added for quilt mods yet (and were disabled for fabric mods), so this is expected (but still a bug).

Sorry, I should have commented much ealier. I plan to write an RFC for improving on the `fabric_loader_dependencies.json` format for quilt's overrides, but I don't plan to change fabric's format....

> have a regular mod depend on a serversided library What do you want this to do? If the regular mod needs the serversided library, then isn't it just a...

Leo brought up a useful suggestion on discord: > Leo, Agent of Cursed — Today at 10:33 man, it's too bad TYPE_USE annotations are weird we could've had public class...

LambdAurora brought up another useful suggestion: > Question then If we have a client only package Does annotating the package will strip all its classes? Loader doesn't do this yet...

As of https://github.com/QuiltMC/quilt-loader/pull/63/commits/a2e988759e4fb29ed6e7a5bc56fdf9889e756af8 this now strips annotated interfaces. For example: ```java @ClientOnlyInterface(IRenderable.class) public class CentrifugeBlockEntity implements IRenderable { } ``` can now be written as: ```java public class CentrifugeBlockEntity implements...

Okay, annotating a `package-info` class with `@ClientOnly` or `@DedicatedServerOnly` now works. I'm not sure if I should remove `@ClientOnlyInterface`, `@ClientOnlyInterfaces`, `@DedicatedServerOnlyInterface` and `@DedicatedServerOnlyInterfaces`, since those just add clutter at this...

While kb-1000 is correct I think we can probably re-expose those fabric metadata legacy interfaces anyway, in the same way that we currently expose other legacy interfaces.