Alexander Hentschel

Suggested compliance revisions

2

This is a list of suggested revisions and improvements that resulted from reviewing [PR #3294](https://github.com/onflow/flow-go/pull/3294). * [ ] in the collector `compliance.Core`, method `OnBlockProposal`, we query the finalized block directly...

Looking at the [`IDTranslator` interface](https://github.com/onflow/flow-go/blob/3539e21e900a85ac3a2786b16fed0753d9ddea3e/network/p2p/id_translator.go): * the interface does not document any error returns * implementations return generic errors leaving higher-level code completely in the dark whether the error is...

FLIP [Draft]: FifoQueue for engines

10

we decided to introduce unblocking message queue(s) for the engines, so that they don’t block the networking layer’s queue and thereby each other. Yurii has already made great progress on...

receipt validator error handling

1

**This PR updates and refines [`ReceiptValidator`](https://github.com/onflow/flow-go/blob/832badbe675513fb3862aae45e02575f6f04aa0f/module/validation/receipt_validator.go)'s internal error handling.** Due to our consistent work on error handling, some of the lower-level components that [`ReceiptValidator`](https://github.com/onflow/flow-go/blob/832badbe675513fb3862aae45e02575f6f04aa0f/module/validation/receipt_validator.go) calls into document their errors better...

### Context In a long-running work, Tarak has replaced the previously used `relic` cryptography library with `BLST`. As a result we are seeing notable block-rate increases in model networks. At...

This issue if for collecting various suggestions, TODOs and tech debt related to the KVStore ## High Prio - [ ] I find it super confusing / misleading that [`Snapshot.EpochProtocolState()`](https://github.com/onflow/flow-go/blob/43c3ceb44c015c8c652ebe5ed43b7d3493971801/state/protocol/snapshot.go#L138-L142)`.`[`Entry()`](https://github.com/onflow/flow-go/blob/43c3ceb44c015c8c652ebe5ed43b7d3493971801/state/protocol/protocol_state.go#L23-L26)...

[EFM] Invalid Service Events shortly after Epoch Commit

1

## Problem description Currently, the `EpochStateMachine`, which orchestrates the Epoch Happy Path and Fallback, has [this behaviour](https://github.com/onflow/flow-go/blob/871174eb00fdc1149bbc1c7bafe94f43fa5a6e4c/state/protocol/protocol_state/epochs/statemachine.go#L191-L219): * As of the block that encounters an invalid Epoch ServiceEvent, we engage...

# Broad system-level overview The following is an overview of which components control the Epoch Fallback Mode [EFM] and which components react to it (all prior to any work on...

Most of the important Engines have been updated. Hence, I would recommend changing the status of this flip to `Released`

► model/flow/filter/identity.go - type `EpochParticipationStatus` currently does not document state transition to "unregistered" ► consensus/hotstuff/committee.go - document that `IdentitiesByBlock` and `IdentityByBlock` omit ejected nodes ► state transition of ejected nodes...