Alexander Hentschel
Alexander Hentschel
@turbolent thanks for the [note](https://github.com/onflow/cadence/issues/1402#issuecomment-1256790591). I might have accidentally commented on the wrong issue. I think my comments should have gone to https://github.com/onflow/developer-grants/issues/23 and https://github.com/onflow/flow/issues/831. Moved my comments there. Sorry...
I think storing large amounts of data in the execution state requires careful consideration. From my perspective, there are 2 different technical angles to this question: 1. Is it conceptually...
file https://github.com/onflow/flow-go/blob/c1e478ed0e4366575be43a77d26cd34f5d7b1b80/integration/tests/epochs/suite.go seems to have multiple compiler errors (maybe it is just a local problem in my IDE?). Didn't look into very much, just wanted to add a note for...
@jordanschalm > [Alex] compiler errors in [`epochs/suite.go`](https://github.com/onflow/flow-go/blob/c1e478ed0e4366575be43a77d26cd34f5d7b1b80/integration/tests/epochs/suite.go) > [Jordan] Do they look like [this](https://github.com/onflow/flow-go/pull/2935#issuecomment-1228951376)? yep exactly. You are saying it is only a local problem? 👌 Then we'll just leave...
High-level design thought: * at the moment, there is some code in the compliance engines, which I feel is legacy from the time when the compliance engine was directly ingesting...
quick request, would you mind clearing up a tiny bit of tech debt as part of this PR 🙏 🙇 👍 * in [this code](https://github.com/onflow/flow-go/blob/62b57dcdea46f005f21b2ed37737df347c89db98/consensus/recovery/follower.go#L18), the variable is still named...
I am not sure whether that [edge case](https://github.com/onflow/flow-go/blob/b4a7dbb4a6b7cf09a481f7eaa49c5bd8057f2427/engine/collection/compliance/core.go#L304-L313) really opens a spamming vulnerability. But here are my thoughts why I am worried: * Personally, I find Moxie Marlinspike's (generalized) [Cryptographic...
Btw, also created issue https://github.com/onflow/flow-go/issues/3374 where I noted suggestions for potential future revisions. Feel free to address points, if you find that they fit nicely within the scope of the...
Generally, I find the terminology "HotStuff validation" and "compliance checks" ambiguous. https://github.com/onflow/flow-go/blob/b4a7dbb4a6b7cf09a481f7eaa49c5bd8057f2427/engine/collection/compliance/core_test.go#L324-L325 This is probably a legacy from our old design, where the compliance engine would check the payload and...
Thank you. Very nice work. I have created [PR #3408](https://github.com/onflow/flow-go/pull/3408) with some stylistic revisions targeting your branch.