Alexander Hentschel

Results 25 comments of Alexander Hentschel

Thanks @jordanschalm for [explaining the motivation behind the naming convention/ terminology](https://github.com/onflow/flow-go/pull/3294#issuecomment-1282354892). Makes sense. Very nice PR altogether!

A cleanliness point (unrelated to this PR): would you mind adding a brief comment about error returns to the implementation here: https://github.com/onflow/flow-go/blob/207e42764f811f65861596e76e9e11ea1dcaa6af/consensus/hotstuff/votecollector/statemachine.go#L176 the interface states: ```golang // It returns nil...

Let us consider the following suggestion: > 1. Once a leader selection for a view range is committed, it can never be overwritten/changed > - A leader selection view range...

see https://github.com/onflow/flow-go/issues/5631 for more details related issues: * https://github.com/onflow/flow-go/issues/5724 is for injecting the first `EpochExtension` (entering EFM). * https://github.com/onflow/flow-go/issues/5726 is for adding `EpochExtension`s on an ongoing basis (maintaining EFM). *...

prerequisite for https://github.com/onflow/flow-go/issues/5730

there might be some overlap with #6013

In the context of this proposal, I would like to emphasize some subtle aspects: * I like this proposal as a pragmatic interim step. However, let us be mindful that...

ideally, the [Consensus Committee](https://github.com/onflow/flow-go/blob/b2c97b5696506c80236821e1856c453e947f634f/consensus/hotstuff/committees/consensus_committee.go#L113-L125) would behave consistently: * it receives events for committed view ranges and _always_ proceeds through those view ranges. * I would explicitly discourage including logic when...

depends on https://github.com/onflow/flow-go/issues/5723

List of places in the code that need updating * `committee.Consensus` on l block finalization: https://github.com/onflow/flow-go/blob/58304e9c4c546ea26f7137dde5889778feae180b/consensus/hotstuff/committees/consensus_committee.go#L182-L189 Caution: This list is likely not exhaustive! Be on the lookout for additional spots...